Upgrade Node.js to 18.20.8 LTS#4
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
- Create .nvmrc file with 18.20.8 - Add engines field to package.json requiring Node.js >=18.0.0 - Update README.md system requirements to Node.js v18.20+ - Build and dependencies tested successfully with Node.js 18.20.8 Co-Authored-By: Arthur Poon <arthur.poon@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Node.js runtime from >=8.15.1 to 18.x LTS
Summary
This PR upgrades the Node.js runtime requirement from
>=8.15.1to18.20.8LTS for both bank-client and bank-server repositories. The upgrade includes necessary compatibility workarounds to handle breaking changes in Node.js 18.x, particularly around OpenSSL and webpack compilation.Key Changes:
.nvmrcfiles to specify Node.js 18.20.8package.jsonengines fields to require>=18.0.0NODE_OPTIONS=--openssl-legacy-providerflag to build script for Webpack 4.x compatibilityReview & Testing Checklist for Human
🔴 HIGH PRIORITY - The following items require careful verification:
--openssl-legacy-provideris acceptable long-term or if dependencies should be updated insteadRecommended Test Plan:
Diagram
%%{ init : { "theme" : "default" }}%% graph TB subgraph "bank-client" nvmrc1[".nvmrc<br/>18.20.8"]:::minor-edit pkg1["package.json<br/>engines + build script"]:::major-edit webpack1["webpack.prod.babel.js<br/>disabled offline-plugin"]:::major-edit readme1["README.md<br/>v18.20+ requirement"]:::minor-edit end subgraph "bank-server" nvmrc2[".nvmrc<br/>18.20.8"]:::minor-edit pkg2["package.json<br/>engines field"]:::major-edit readme2["README.md<br/>v18.20+ requirement"]:::minor-edit end subgraph "Runtime Environment" node["Node.js 18.20.8<br/>LTS"]:::context webpack_build["Webpack Build<br/>Process"]:::context pwa["PWA Features<br/>(offline-plugin)"]:::context end pkg1 -.->|"NODE_OPTIONS flag"| webpack_build webpack1 -.->|"disabled"| pwa nvmrc1 --> node nvmrc2 --> node subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
--openssl-legacy-providerflag and disabled offline-plugin are temporary solutions. Consider updating to newer versions of Webpack and finding an offline-plugin alternative for long-term maintainability.Link to Devin run: https://app.devin.ai/sessions/6efa8cac6bb747139dd99524406c0b65
Requested by: Arthur Poon (@akkp-windsurf)